Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add customFields on subscriptionFields #34206

Merged
merged 3 commits into from
Dec 18, 2024
Merged

chore: add customFields on subscriptionFields #34206

merged 3 commits into from
Dec 18, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 17, 2024 •
edited
Loading

found this issue during:
rocketchat.atlassian.net/browse/CORE-811

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 17, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: daeb562

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo changed the title chore: wip chore: add customFields on subscriptionFields Dec 17, 2024
@ggazzo ggazzo added this to the 7.2.0 milestone Dec 17, 2024
@ggazzo ggazzo marked this pull request as ready for review December 17, 2024 21:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34206/
on branch gh-pages at 2024-12-18 13:55 UTC

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (0fcdc3e) to head (daeb562).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34206      +/-   ##
===========================================
- Coverage    75.83%   75.81%   -0.03%     
===========================================
  Files          511      512       +1     
  Lines        22172    22205      +33     
  Branches      5397     5403       +6     
===========================================
+ Hits         16814    16834      +20     
- Misses        4710     4720      +10     
- Partials       648      651       +3
Flag Coverage Δ
unit 75.81% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo requested a review from a team as a code owner December 18, 2024 13:51
@ggazzo ggazzo merged commit 619f133 into develop Dec 18, 2024
46 of 48 checks passed
@ggazzo ggazzo deleted the chore/tmp branch December 18, 2024 18:43
MartinSchoeler pushed a commit that referenced this pull request Dec 30, 2024
@ggazzo @MartinSchoeler
chore: add customFields on subscriptionFields (#34206)
e84e369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevLehman KevLehman KevLehman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @KevLehman